Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP34 token_uri metadata #74

Merged
merged 1 commit into from
Jul 6, 2023
Merged

PSP34 token_uri metadata #74

merged 1 commit into from
Jul 6, 2023

Conversation

boyswan
Copy link
Contributor

@boyswan boyswan commented Jul 6, 2023

Currently we have our own nft_metadata storage which we use for assigning metadata to tokens. PSP34Metadata provides it's own solution for storing metadata (attributes), which we are using for collections but not tokens.

This PR removes our custom nft_metadata storage, and instead uses the PSP34Metedata attribute implementation. The benefit here is we can access token metadata via the public ink PSPS34Metadata_get_attribute function, as well as the provided token_uri() function.

I have also fixed a discrepancy where token_uri was accepting a u64 instead of an Id type.

@boyswan boyswan requested a review from Maar-io July 6, 2023 10:36
Copy link
Contributor

@Maar-io Maar-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boyswan boyswan merged commit f909d2c into main Jul 6, 2023
2 of 4 checks passed
@boyswan boyswan deleted the feature/use-psp34-metadata branch July 6, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants